Fix/bottom tap while gesture confirm #1616
Open
+24
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
fix/bottom-tap-while-gesture-confirm
branch
2 times, most recently
from
f7cc93b to
2fa485b
Compare
Previously the confirm gesture component would get "out of active" as soon as the top slider was released. If one released the top slider before the top slider it would often trigger a keyboard press. This commit creates an additional boolean that keeps the "active" state in "active" until the drawing is reset to it's original state thus removing the risk of unintentional keyboard presses. The confirm gesture is also given a "higher priority" by being rendered last.
NickeZ
force-pushed
the
fix/bottom-tap-while-gesture-confirm
branch
from
2fa485b to
f271546
Compare
benma
reviewed
Oct 10, 2025
Comment on lines
+244
to
+245
| // Render confirm button or gesture (render confirm gesture last so that bottom triangle is | ||
| // above keyboard) |
There was a problem hiding this comment.
so that bottom triangle is above keyboard
The keyboard is not rendered while the confirm gesture is active. Is this comment about something else?
There was a problem hiding this comment.
Not true, you can clearly see the bottom triangle "animating out" beneath the keyboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.